Use existing files on disk instead of pushing afresh #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rich FitzJohn <[email protected]>
r-ash
force-pushed
the
use-files-from-disk
branch
from
c5dd3fb to
536077f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 40 40
Lines 3621 3626 +5
=========================================
+ Hits 3621 3626 +5 ☔ View full report in Codecov by Sentry. |
richfitz
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this when doing the Python impl, in particular here mrc-ide/pyorderly#33 (comment)
We have logic which checks if a file is already known on disk somewhere and then adds this into a temporary filestore. We are not then removing that from the list of files to fetch from the location. I've added a test which checks this case and updated this
Note this is failing due to an outpack_server change, Mantra has included the fix for this on his PR #122 so we should merge this after that