Remove root src #130
Merged
Remove root src #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 40 40
Lines 3626 3626
=========================================
Hits 3626 3626 ☔ View full report in Codecov by Sentry. |
M-Kusumgar
commented
Mar 4, 2024
R/run.R
Outdated
| root <- root_open(root, locate, require_orderly = TRUE, | ||
| call = environment()) | ||
| search_options = NULL, root = NULL, locate = TRUE) { | ||
| env_src <- Sys.getenv("ORDERLY_REPORT_SRC") |
There was a problem hiding this comment.
Suggested change
| env_src <- Sys.getenv("ORDERLY_REPORT_SRC") | |
| env_src <- Sys.getenv("ORDERLY_SRC_ROOT", NA_character_) |
M-Kusumgar
commented
Mar 4, 2024
R/run.R
Outdated
| call = environment()) | ||
| search_options = NULL, root = NULL, locate = TRUE) { | ||
| env_src <- Sys.getenv("ORDERLY_REPORT_SRC") | ||
| is_env_src_empty <- !nzchar(env_src) |
There was a problem hiding this comment.
Suggested change
| is_env_src_empty <- !nzchar(env_src) | |
| is_env_src_empty <- is.na(env_src) |
r-ash
approved these changes
Mar 5, 2024
richfitz
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to specify
root_srcvia an environment variableORDERLY_SRC_ROOTinstead of users being able to pass this in as an argument. This is good because we don't really need the users to be passing in theirroot_src.