Make tests more isolated. #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests were calling `orderly_run` without an `envir` parameter, which ends up running the report in the global environment. This pollutes that namespace and might affect subsequent tests. One particular issue I was hitting was a test depending on the global `data` name from `utils`, while other tests were defining a global variable with that (unfortunately very common) name. I've added a `envir = new.env()` parameter to all the `orderly_run` calls I could find, and changed the test that depended on `data` to use the fully qualified name `utils::base`. Running the whole test suite now leaves an unmodified global environment: ```r ls() # character(0) devtools::test() ls() # character(0) ```
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 40 40
Lines 3628 3671 +43
=========================================
+ Hits 3628 3671 +43 ☔ View full report in Codecov by Sentry. |
richfitz
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests were calling
orderly_runwithout anenvirparameter,which ends up running the report in the global environment. This
pollutes that namespace and might affect subsequent tests.
One particular issue I was hitting was a test depending on the global
dataname fromutils, while other tests were defining a globalvariable with that (unfortunately very common) name.
I've added a
envir = new.env()parameter to all theorderly_runcalls I could find, and changed the test that depended on
datato usethe fully qualified name
utils::base.Running the whole test suite now leaves an unmodified global
environment: