mrc-5483: Fix issue when pulling multiple packets with multiple files #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue spotted by Jeff when pulling packets
This is happening because if we pull with a query which finds multiple packets which are at more than 1 location then we're not matching up the location to the file information correctly. In particular, if the packets have a total number of files which is not a multiple of the number of locations then this errors 🙈 Expect we've not seen this in our other tests because we're always creating 1 file in the test data. This PR adds a test to recreate the issue and fixes it.
I tidied up the docs here a little bit too. But Jeff was definitely a bit confused about this interface, he was expecting passing
name = "..."
to only pull the latest with that name. It wasn't immediately obvious to him that this would pull all of them, and I can see why. Will leave this for @M-Kusumgar to discuss