Fix tests on R-devel. #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of yesterday, the development version of R preserves names in its implementation of `setdiff` (and other set-like operations). This has changed the behaviour of `root_list_unknown_packets` to also preserves names, which broke some tests that were a little too strict about it. ``` $ docker run -it rocker/r-ver:devel R -s -e 'dput(setdiff(c(a=1), NULL))' c(a = 1) $ docker run -it rocker/r-ver:4.4 R -s -e 'dput(setdiff(c(a=1), NULL))' 1 ``` See r-devel/r-svn@982288a for the offending upstream change.
plietar
force-pushed
the
fix-tests-devel
branch
from
fcb9e4b to
9b38e9f
Compare
richfitz
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of yesterday, the development version of R preserves names in its implementation of
setdiff(and other set-like operations). This has changed the behaviour ofroot_list_unknown_packetsto also preserves names, which broke some tests that were a little too strict about it.See r-devel/r-svn@982288a for the offending upstream change.