Improve handling of deleted implicit inputs. #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plietar
force-pushed
the
mrc-5735-delete-implicit
branch
2 times, most recently
from
3e5ffc2 to
f03a909
Compare
|
I'm kind of on the fence about whether this even deserves a warning at all. There's nothing really actionable the user can do other than not writing weird reports. |
richfitz
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Thanks, and for getting this found and fixed so quickly.
I'm kind of on the fence about whether this even deserves a warning at all. There's nothing really actionable the user can do other than not writing weird reports.
The intention had been to expose something like outpack_packet_file_mark to mark files as ignored; we should expose some mechanism for doing this and hint at it in the warning. But I think do that in a subsequent PR
In implicit mode, orderly prints a message if some of the implicit inputs have been modified by the report. However the code to enumerate modified files did not properly handle files that have been deleted. When that happens, `fs::file_info` return NA in all the metadata columns. We now detect these files and display a slightly different warning for it. Cleaned up a bit of adjacent code: switch from handcrafted bullet points to using `cli::cli_ul`, fixed some tests which had used `suppressMessages` when they could have used `orderly_run_quietly`.
plietar
force-pushed
the
mrc-5735-delete-implicit
branch
from
f03a909 to
1e1f24e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In implicit mode, orderly prints a message if some of the implicit inputs have been modified by the report. However the code to enumerate modified files did not properly handle files that have been deleted. When that happens,
fs::file_inforeturn NA in all the metadata columns.We now detect these files and display a slightly different warning for it.
Cleaned up a bit of adjacent code: switch from handcrafted bullet points to using
cli::cli_ul, fixed some tests which had usedsuppressMessageswhen they could have usedorderly_run_quietly.