Propagate name parameter in match_value. #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@richfitz do you know what the |
Without this, when the first argument of `match_value` was not a valid
character scalar, the function would unconditionally call it `x`, even
if the caller's code makes no mention of `x`.
```r
match_value(5, list("foo", "bar"))
#> Error:
#> ! 'x' must be character
```
With this change, the name as used in the caller of `match_value` is
used, which gives a less confusing output:
```r
match_value(5, list("foo", "bar"))
#> Error:
#> ! '5' must be character
```
plietar
force-pushed
the
match_value_name
branch
from
4c9ddec to
fd773ca
Compare
richfitz
approved these changes
Sep 5, 2024
|
See I've tidied a few of these things up as https://github.com/reside-ic/reside.utils/ which we can pull in for reuse in orderly among others, I'll get a PR together for this perhaps on the train on the way home tonight |
richfitz
added a commit
to reside-ic/reside.utils
that referenced
this pull request
Sep 10, 2024
Originally fixed in mrc-ide/orderly2#175
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, when the first argument of
match_valuewas not a valid character scalar, the function would unconditionally call itx, even if the caller's code makes no mention ofx.With this change, the name as used in the caller of
match_valueis used, which gives a less confusing output: