Drop locate argument everywhere public-facing
#183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plietar
approved these changes
Oct 17, 2024
R/root.R
Outdated
| @@ -140,7 +139,7 @@ empty_config_contents <- function() { | |||
| ## * also check that the outpack and orderly path are compatibible | |||
| ## (this is actually quite hard to get right, but should be done | |||
| ## before anything is created I think) | |||
| root_open <- function(path, locate, require_orderly = FALSE, call = NULL) { | |||
| root_open <- function(path, require_orderly = FALSE, call = parent.frame()) { | |||
| if (is.null(call)) { | |||
There was a problem hiding this comment.
Can we remove this line? Presumably no where calls this with an explicit call = NULL.
R/root.R
Outdated
| @@ -140,7 +139,7 @@ empty_config_contents <- function() { | |||
| ## * also check that the outpack and orderly path are compatibible | |||
| ## (this is actually quite hard to get right, but should be done | |||
| ## before anything is created I think) | |||
| root_open <- function(path, locate, require_orderly = FALSE, call = NULL) { | |||
| root_open <- function(path, require_orderly = FALSE, call = parent.frame()) { | |||
There was a problem hiding this comment.
Seems you've added values for require_orderly everywhere - would it be worth removing the default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops the
locateargument which was inconsistently present, had inconsistent arguments and was inconsistently used. We now search for the root fromroot(usuallyNULL) in all cases.Calls to
root_openhave been slightly simplified by adding a reasonable default forcall; doing that everywhere is another bit of maintenance we can do later