Indicate if extracted metadata is local or not #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-Kusumgar
reviewed
Oct 22, 2024
R/outpack_tools.R
Outdated
Comment on lines
229
to
234
| if (isTRUE(allow_remote) || length(location) > 0) { | ||
| ret$local <- ids %in% root$index$unpacked() | ||
| } |
There was a problem hiding this comment.
local boolean is good, but do we not have any way of having a "location" column too that has "local" as a special value and the name of other locations? i can imagine users potentially wanting info about what remote location a packet is in
There was a problem hiding this comment.
agree that this would be nicer....but as packets can be found at multiple locations it's awkward as we have to return a list column. If we think that's worth it it's very easy to add, but they're a bit of a pain to use imo (we do return them liberally elsewhere in this function though)
There was a problem hiding this comment.
OK, I think this is worthwhile and have done it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More from Jeff's request in #156 - an indication of metadata refers to a packet available locally.