Cope better with relative locations #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plietar
approved these changes
Oct 23, 2024
| "which exists, but does not exist relatively to", | ||
| "'{root$path}', the root of your orderly archive"), | ||
| i = "Consider passing '{root_fix}' instead")) | ||
| } |
There was a problem hiding this comment.
This is really nice diagnostics! Really solves the problem of having to choose between two equally acceptable behaviours.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we allowed relative paths to be used for locations but it was ambiguous where they were looked up. This is a problem in contexts where absolute paths are not suitable (e.g., on the cluster where the mount point on the nodes is different to the submitting workstation).
This PR removes the ambiguity - we take the path relative to the root, and not relative to the command that calls
orderly_location_add_path(). This might be confusing so there's a special case error that we throw if it looks like the wrong relative path was chosen.When we load the driver we change back to the root and then interpret the path at that point. This is also done when the user verifies addition (in #188).