Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documenting comments to orderly.json schema #201

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

david-mears-2
Copy link
Contributor

To clarify the intent behind the properties/what terms refer to

To clarify the intent behind the properties/what terms refer to
@david-mears-2
Copy link
Contributor Author

Unfortunately the 'windows-latest' R-CMD-check fails. I re-ran it and it failed again.

@plietar
Copy link
Member

plietar commented Dec 3, 2024

@richfitz how is this schema coordinated across repos (if at all)?

We have https://github.com/mrc-ide/outpack for the outpack schemas, but I can't find any equivalent for orderly.json.


EDIT: Seems this is the one and only copy of that file that we have: https://github.com/search?q=org%3Amrc-ide+path%3Aorderly.json&type=code, so making this PR here seems good. At some point we should move it somewhere global, the outpack repo seems reasonable to me.

@plietar
Copy link
Member

plietar commented Dec 3, 2024

I couldn't reproduce the build failure on a Windows VM 😞

@richfitz
Copy link
Member

richfitz commented Dec 3, 2024

The idea was that orderly2 is responsible for its schemas, it would hold them itself. It imports schemas from outpack (there's a script somewhere to pull them in)

@richfitz richfitz merged commit d9ab97c into main Dec 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants