Update volatility factor and compute max withdraw

for bank
mrgnlabs · Dec 13, 2023 · 89680f6 · 89680f6 · vercel · Dec 13, 2023
1 parent 0a192ea
commit 89680f6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/packages/marginfi-client-v2/src/models/account/pure.ts b/packages/marginfi-client-v2/src/models/account/pure.ts
@@ -305,7 +305,10 @@ class MarginfiAccount {
     }
 
     // apply volatility factor to avoid failure due to price volatility / slippage
-    const initUntiedCollateralForBank = freeCollateral.times(_volatilityFactor);
+    // initCollateralForBank > freeCollateral, so volatilityBuffer > 0
+    const volatilityBuffer = (initCollateralForBank.minus(freeCollateral)).times(1 - _volatilityFactor);
+    const initUntiedCollateralForBank = freeCollateral.minus(volatilityBuffer);
+
     const priceLowestBias = bank.getPrice(priceInfo, PriceBias.Lowest);
     const initWeightedPrice = priceLowestBias.times(initAssetWeight);
     const maxWithdraw = initUntiedCollateralForBank.div(initWeightedPrice);

diff --git a/packages/marginfi-v2-ui-state/src/lib/mrgnlend.ts b/packages/marginfi-v2-ui-state/src/lib/mrgnlend.ts
@@ -23,7 +23,7 @@ import { Connection, PublicKey, SystemProgram } from "@solana/web3.js";
 import BN from "bn.js";
 
 const FEE_MARGIN = 0.01;
-const VOLATILITY_FACTOR = 0.98;
+const VOLATILITY_FACTOR = 0.975;
 
 const DEFAULT_ACCOUNT_SUMMARY = {
   healthFactor: 0,
@@ -347,7 +347,7 @@ function makeExtendedBankInfo(
 
   const maxWithdraw = floor(
     Math.min(
-      marginfiAccount.computeMaxWithdrawForBank(bank.address).toNumber(),
+      marginfiAccount.computeMaxWithdrawForBank(bank.address, { volatilityFactor: VOLATILITY_FACTOR }).toNumber(),
       bankInfo.availableLiquidity
     ),
     bankInfo.mintDecimals