Add 10Cap valuation (closes #88) #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocielnik
changed the title
Closed
|
Let me know once this is ready for review :) |
kocielnik
force-pushed
the
valuation-10cap
branch
from
81247c3 to
aac02de
Compare
I expect the breaking of this test to be fixed by PR mrhappyasthma#92.
kocielnik
commented
Dec 6, 2024
| @@ -90,7 +90,7 @@ | |||
|
|
|||
| this.shadowRoot.append(style, wrapper); | |||
|
|
|||
| this.animationTimeout = None; | |||
There was a problem hiding this comment.
Appeared in the browser console as:
| class="form-control" | ||
| id="ticker" | ||
| placeholder="Ticker Symbol" | ||
| maxlength=8 | ||
| onkeydown="return validateInput(event)"/> |
There was a problem hiding this comment.
Appeared in the browser console as:
| @@ -4,11 +4,11 @@ | |||
| <div class="col-md-3 nopadding"> | |||
| <input | |||
| type="text" | |||
| autofocus | |||
There was a problem hiding this comment.
Causes the search field to get activated automatically on each visit to the site (including page refresh).
@mrhappyasthma, if you see problems with this behaviour, please let me know! :)
Actually, the purpose of this commit is to bump the CI to run again, because it failed with an error that seems intermittent, and very rare.
@mrhappyasthma, ready for review! :) |
|
I've just noticed I needed to "undraft" it too. Done! :) |
Before: ten_cap("NVDA") = 10.834
After: ten_cap("NVDA") = 10.83
|
@mrhappyasthma, preview of the app with both pending PRs merged: |
|
Looks good to me. The small fixes are all good as well. mostly obsolete stuff that we never removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example - MSFT above 10 Cap price:
Example - PLBC below 10 Cap price: