Skip to content

Commit

Permalink
ci: try windows-2022
Browse files Browse the repository at this point in the history
  • Loading branch information
qvalentin committed Mar 10, 2024
1 parent 961e34f commit 434f999
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
9 changes: 1 addition & 8 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
strategy:
matrix:
go-version: [1.21.5]
os: [windows-2019]
os: [windows-2022]
runs-on: ${{ matrix.os }}
steps:

Expand All @@ -42,15 +42,8 @@ jobs:
with:
go-version: ${{ matrix.go-version }}

- name: Set up MinGW
uses: egor-tensin/setup-mingw@v2
with:
version: 12.2.0

- name: Checkout code
uses: actions/checkout@v4

- name: Run tests
run: make test
env:
CC: "cc"
5 changes: 1 addition & 4 deletions internal/adapter/yamlls/diagnostics.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ func diagnisticIsRelevant(diagnostic lsp.Diagnostic, node *sitter.Node) bool {
case "All mapping items must start at the same column":
// unknown what exactly this is, only causes one error in bitnami/charts
return false
case "Implicit map keys need to be followed by map values":
case "Implicit map keys need to be followed by map values", "A block sequence may not be used as an implicit map key", "Implicit keys need to be on a single line":
// still breaks with
// params:
// {{- range $key, $value := .params }}
Expand All @@ -67,9 +67,6 @@ func diagnisticIsRelevant(diagnostic lsp.Diagnostic, node *sitter.Node) bool {
// {{- end }}
// {{- end }}
return false && !lsplocal.IsInElseBranch(node)
case "Implicit keys need to be on a single line":
// beaks for same as above
return false
case "Block scalars with more-indented leading empty lines must use an explicit indentation indicator":
// TODO: check if this is a false positive, probably requires parsing the yaml with tree-sitter injections
// smtp-password: |
Expand Down

0 comments on commit 434f999

Please sign in to comment.