test(definition): fix tests

mrjosh · Mar 31, 2024 · 6c8523e · 6c8523e
1 parent 13c5680
commit 6c8523e
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 9 deletions.
diff --git a/internal/handler/definition_test.go b/internal/handler/definition_test.go
@@ -160,12 +160,12 @@ func TestDefinitionValueInList(t *testing.T) {
 			URI: testValuesURI,
 			Range: lsp.Range{
 				Start: lsp.Position{
-					Line:      3,
-					Character: 2,
+					Line:      4,
+					Character: 0,
 				},
 				End: lsp.Position{
-					Line:      3,
-					Character: 2,
+					Line:      4,
+					Character: 0,
 				},
 			},
 		},
@@ -201,7 +201,11 @@ func TestDefinitionValueFile(t *testing.T) {
 			URI: testValuesURI,
 			Range: lsp.Range{
 				Start: lsp.Position{
-					Line:      0,
+					Line:      1,
+					Character: 0,
+				},
+				End: lsp.Position{
+					Line:      1,
 					Character: 0,
 				},
 			},
@@ -265,15 +269,23 @@ func TestDefinitionValueFileMulitpleValues(t *testing.T) {
 			URI: testValuesURI,
 			Range: lsp.Range{
 				Start: lsp.Position{
-					Line:      0,
+					Line:      1,
+					Character: 0,
+				},
+				End: lsp.Position{
+					Line:      1,
 					Character: 0,
 				},
 			},
 		}, {
 			URI: testOtherValuesURI,
 			Range: lsp.Range{
 				Start: lsp.Position{
-					Line:      0,
+					Line:      1,
+					Character: 0,
+				},
+				End: lsp.Position{
+					Line:      1,
 					Character: 0,
 				},
 			},

diff --git a/internal/handler/hover_main_test.go b/internal/handler/hover_main_test.go
@@ -95,6 +95,15 @@ func TestHoverMain(t *testing.T) {
 			expected:      fmt.Sprintf("### %s\n%s\n\n", filepath.Join("..", "..", "testdata", "example", "values.yaml"), "ingress.hosts:\n- host: chart-example.local\n  paths:\n  - path: /\n    pathType: ImplementationSpecific\n"),
 			expectedError: nil,
 		},
+		{
+			desc: "Test not existing values list",
+			position: lsp.Position{
+				Line:      101,
+				Character: 35,
+			},
+			expected:      "",
+			expectedError: fmt.Errorf("Could not parse ast correctly"),
+		},
 	}
 	for _, tt := range testCases {
 		t.Run(tt.desc, func(t *testing.T) {
@@ -130,7 +139,9 @@ func TestHoverMain(t *testing.T) {
 				},
 			})
 			assert.Equal(t, tt.expectedError, err)
-			assert.Equal(t, tt.expected, result.Contents.Value)
+			if err == nil {
+				assert.Equal(t, tt.expected, result.Contents.Value)
+			}
 		})
 	}
 }
diff --git a/internal/handler/hover_test.go b/internal/handler/hover_test.go
@@ -95,7 +95,9 @@ nested: value
 				splittedVar: []string{"key"},
 			},
 			want: `### values.yaml
-[map[nested:value]]
+key:
+- nested: value
+
 
 `,
 			wantErr: false,

diff --git a/testdata/example/templates/deployment.yaml b/testdata/example/templates/deployment.yaml
@@ -69,3 +69,4 @@ spec:
         {{- if $.Files.Glob "files/dags/*.py" }}
         {{- end }}
       {{- end }}
+      hosts: {{ .Values.ingress.hosts }}