fix(yamlls): check if yamlls is enabled for symbol

mrjosh · Jul 28, 2024 · c20d90f · c20d90f
1 parent cd29aa2
commit c20d90f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/internal/adapter/yamlls/symbol.go b/internal/adapter/yamlls/symbol.go
@@ -7,7 +7,7 @@ import (
 )
 
 func (yamllsConnector Connector) CallDocumentSymbol(ctx context.Context, params *lsp.DocumentSymbolParams) (result []interface{}, err error) {
-	if yamllsConnector.server == nil {
+	if !yamllsConnector.shouldRun(params.TextDocument.URI) {
 		return []interface{}{}, nil
 	}
 	return yamllsConnector.server.DocumentSymbol(ctx, params)

diff --git a/internal/adapter/yamlls/symbol_integration_test.go b/internal/adapter/yamlls/symbol_integration_test.go
@@ -28,6 +28,10 @@ func TestYamllsDocumentSymoblIntegration(t *testing.T) {
 			file:        "../../../testdata/example/templates/ingress.yaml",
 			expectedLen: 6,
 		},
+		{
+			file:        "../../../testdata/example/templates/_helpers.tpl",
+			expectedLen: 0,
+		},
 	}
 	for _, tt1 := range testCases {
 		tt := tt1