Skip to content

Commit

Permalink
Merge pull request #74 from mrjosh/fix/unimplemented-errors
Browse files Browse the repository at this point in the history 
fix(handler): remove all unimplemented panics (#73)
  • Loading branch information
@qvalentin
qvalentin authored Apr 10, 2024
2 parents 74c9fdb + 4bcbf29 commit e7a765e
Show file tree
Hide file tree
Showing 2 changed files with 95 additions and 48 deletions.
134 changes: 89 additions & 45 deletions internal/handler/handler.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,182 +60,217 @@ func newHandler(connPool jsonrpc2.Conn, client protocol.Client) *langHandler {

// CodeAction implements protocol.Server.
func (h *langHandler) CodeAction(ctx context.Context, params *lsp.CodeActionParams) (result []lsp.CodeAction, err error) {
panic("unimplemented")
logger.Error("Code action unimplemented")
return nil, nil
}

// CodeLens implements protocol.Server.
func (h *langHandler) CodeLens(ctx context.Context, params *lsp.CodeLensParams) (result []lsp.CodeLens, err error) {
panic("unimplemented")
logger.Error("Code lens unimplemented")
return nil, nil
}

// CodeLensRefresh implements protocol.Server.
func (h *langHandler) CodeLensRefresh(ctx context.Context) (err error) {
panic("unimplemented")
logger.Error("Code lens refresh unimplemented")
return nil
}

// CodeLensResolve implements protocol.Server.
func (h *langHandler) CodeLensResolve(ctx context.Context, params *lsp.CodeLens) (result *lsp.CodeLens, err error) {
panic("unimplemented")
logger.Error("Code lens resolve unimplemented")
return nil, nil
}

// ColorPresentation implements protocol.Server.
func (h *langHandler) ColorPresentation(ctx context.Context, params *lsp.ColorPresentationParams) (result []lsp.ColorPresentation, err error) {
panic("unimplemented")
logger.Error("Color presentation unimplemented")
return nil, nil
}

// CompletionResolve implements protocol.Server.
func (h *langHandler) CompletionResolve(ctx context.Context, params *lsp.CompletionItem) (result *lsp.CompletionItem, err error) {
panic("unimplemented")
logger.Error("Completion resolve unimplemented")
return nil, nil
}

// Declaration implements protocol.Server.
func (h *langHandler) Declaration(ctx context.Context, params *lsp.DeclarationParams) (result []lsp.Location, err error) {
panic("unimplemented")
logger.Error("Declaration unimplemented")
return nil, nil
}

// DidChangeWorkspaceFolders implements protocol.Server.
func (h *langHandler) DidChangeWorkspaceFolders(ctx context.Context, params *lsp.DidChangeWorkspaceFoldersParams) (err error) {
panic("unimplemented")
logger.Error("DidChangeWorkspaceFolders unimplemented")
return nil
}

// DocumentColor implements protocol.Server.
func (h *langHandler) DocumentColor(ctx context.Context, params *lsp.DocumentColorParams) (result []lsp.ColorInformation, err error) {
panic("unimplemented")
logger.Error("Document color unimplemented")
return nil, nil
}

// DocumentHighlight implements protocol.Server.
func (h *langHandler) DocumentHighlight(ctx context.Context, params *lsp.DocumentHighlightParams) (result []lsp.DocumentHighlight, err error) {
panic("unimplemented")
logger.Error("Document highlight unimplemented")
return nil, nil
}

// DocumentLink implements protocol.Server.
func (h *langHandler) DocumentLink(ctx context.Context, params *lsp.DocumentLinkParams) (result []lsp.DocumentLink, err error) {
panic("unimplemented")
logger.Error("Document link unimplemented")
return nil, nil
}

// DocumentLinkResolve implements protocol.Server.
func (h *langHandler) DocumentLinkResolve(ctx context.Context, params *lsp.DocumentLink) (result *lsp.DocumentLink, err error) {
panic("unimplemented")
logger.Error("Document link resolve unimplemented")
return nil, nil
}

// DocumentSymbol implements protocol.Server.
func (h *langHandler) DocumentSymbol(ctx context.Context, params *lsp.DocumentSymbolParams) (result []interface{}, err error) {
panic("unimplemented")
logger.Error("Document symbol unimplemented")
return nil, nil
}

// ExecuteCommand implements protocol.Server.
func (h *langHandler) ExecuteCommand(ctx context.Context, params *lsp.ExecuteCommandParams) (result interface{}, err error) {
panic("unimplemented")
logger.Error("Execute command unimplemented")
return nil, nil
}

// Exit implements protocol.Server.
func (h *langHandler) Exit(ctx context.Context) (err error) {
panic("unimplemented")
return nil
}

// FoldingRanges implements protocol.Server.
func (h *langHandler) FoldingRanges(ctx context.Context, params *lsp.FoldingRangeParams) (result []lsp.FoldingRange, err error) {
panic("unimplemented")
logger.Error("Folding ranges unimplemented")
return nil, nil
}

// Formatting implements protocol.Server.
func (h *langHandler) Formatting(ctx context.Context, params *lsp.DocumentFormattingParams) (result []lsp.TextEdit, err error) {
panic("unimplemented")
logger.Error("Formatting unimplemented")
return nil, nil
}

// Implementation implements protocol.Server.
func (h *langHandler) Implementation(ctx context.Context, params *lsp.ImplementationParams) (result []lsp.Location, err error) {
panic("unimplemented")
logger.Error("Implementation unimplemented")
return nil, nil
}

// IncomingCalls implements protocol.Server.
func (h *langHandler) IncomingCalls(ctx context.Context, params *lsp.CallHierarchyIncomingCallsParams) (result []lsp.CallHierarchyIncomingCall, err error) {
panic("unimplemented")
logger.Error("Incoming calls unimplemented")
return nil, nil
}

// LinkedEditingRange implements protocol.Server.
func (h *langHandler) LinkedEditingRange(ctx context.Context, params *lsp.LinkedEditingRangeParams) (result *lsp.LinkedEditingRanges, err error) {
panic("unimplemented")
logger.Error("Linked editing range unimplemented")
return nil, nil
}

// LogTrace implements protocol.Server.
func (h *langHandler) LogTrace(ctx context.Context, params *lsp.LogTraceParams) (err error) {
panic("unimplemented")
logger.Error("Log trace unimplemented")
return nil
}

// Moniker implements protocol.Server.
func (h *langHandler) Moniker(ctx context.Context, params *lsp.MonikerParams) (result []lsp.Moniker, err error) {
panic("unimplemented")
logger.Error("Moniker unimplemented")
return nil, nil
}

// OnTypeFormatting implements protocol.Server.
func (h *langHandler) OnTypeFormatting(ctx context.Context, params *lsp.DocumentOnTypeFormattingParams) (result []lsp.TextEdit, err error) {
panic("unimplemented")
logger.Error("On type formatting unimplemented")
return nil, nil
}

// OutgoingCalls implements protocol.Server.
func (h *langHandler) OutgoingCalls(ctx context.Context, params *lsp.CallHierarchyOutgoingCallsParams) (result []lsp.CallHierarchyOutgoingCall, err error) {
panic("unimplemented")
logger.Error("Outgoing calls unimplemented")
return nil, nil
}

// PrepareCallHierarchy implements protocol.Server.
func (h *langHandler) PrepareCallHierarchy(ctx context.Context, params *lsp.CallHierarchyPrepareParams) (result []lsp.CallHierarchyItem, err error) {
panic("unimplemented")
logger.Error("Prepare call hierarchy unimplemented")
return nil, nil
}

// PrepareRename implements protocol.Server.
func (h *langHandler) PrepareRename(ctx context.Context, params *lsp.PrepareRenameParams) (result *lsp.Range, err error) {
panic("unimplemented")
logger.Error("Prepare rename unimplemented")
return nil, nil
}

// RangeFormatting implements protocol.Server.
func (h *langHandler) RangeFormatting(ctx context.Context, params *lsp.DocumentRangeFormattingParams) (result []lsp.TextEdit, err error) {
panic("unimplemented")
logger.Error("Range formatting unimplemented")
return nil, nil
}

// References implements protocol.Server.
func (h *langHandler) References(ctx context.Context, params *lsp.ReferenceParams) (result []lsp.Location, err error) {
panic("unimplemented")
logger.Error("References unimplemented")
return nil, nil
}

// Rename implements protocol.Server.
func (h *langHandler) Rename(ctx context.Context, params *lsp.RenameParams) (result *lsp.WorkspaceEdit, err error) {
panic("unimplemented")
logger.Error("Rename unimplemented")
return nil, nil
}

// Request implements protocol.Server.
func (h *langHandler) Request(ctx context.Context, method string, params interface{}) (result interface{}, err error) {
panic("unimplemented")
logger.Error("Request unimplemented")
return nil, nil
}

// SemanticTokensFull implements protocol.Server.
func (h *langHandler) SemanticTokensFull(ctx context.Context, params *lsp.SemanticTokensParams) (result *lsp.SemanticTokens, err error) {
panic("unimplemented")
logger.Error("Semantic tokens full unimplemented")
return nil, nil
}

// SemanticTokensFullDelta implements protocol.Server.
func (h *langHandler) SemanticTokensFullDelta(ctx context.Context, params *lsp.SemanticTokensDeltaParams) (result interface{}, err error) {
panic("unimplemented")
logger.Error("Semantic tokens full delta unimplemented")
return nil, nil
}

// SemanticTokensRange implements protocol.Server.
func (h *langHandler) SemanticTokensRange(ctx context.Context, params *lsp.SemanticTokensRangeParams) (result *lsp.SemanticTokens, err error) {
panic("unimplemented")
logger.Error("Semantic tokens range unimplemented")
return nil, nil
}

// SemanticTokensRefresh implements protocol.Server.
func (h *langHandler) SemanticTokensRefresh(ctx context.Context) (err error) {
panic("unimplemented")
logger.Error("Semantic tokens refresh unimplemented")
return nil
}

// SetTrace implements protocol.Server.
func (h *langHandler) SetTrace(ctx context.Context, params *lsp.SetTraceParams) (err error) {
panic("unimplemented")
logger.Error("Set trace unimplemented")
return nil
}

// ShowDocument implements protocol.Server.
func (h *langHandler) ShowDocument(ctx context.Context, params *lsp.ShowDocumentParams) (result *lsp.ShowDocumentResult, err error) {
panic("unimplemented")
logger.Error("Show document unimplemented")
return nil, nil
}

// Shutdown implements protocol.Server.
Expand All @@ -245,45 +280,54 @@ func (h *langHandler) Shutdown(ctx context.Context) (err error) {

// SignatureHelp implements protocol.Server.
func (h *langHandler) SignatureHelp(ctx context.Context, params *lsp.SignatureHelpParams) (result *lsp.SignatureHelp, err error) {
panic("unimplemented")
logger.Error("Signature help unimplemented")
return nil, nil
}

// Symbols implements protocol.Server.
func (h *langHandler) Symbols(ctx context.Context, params *lsp.WorkspaceSymbolParams) (result []lsp.SymbolInformation, err error) {
panic("unimplemented")
logger.Error("Symbols unimplemented")
return nil, nil
}

// TypeDefinition implements protocol.Server.
func (h *langHandler) TypeDefinition(ctx context.Context, params *lsp.TypeDefinitionParams) (result []lsp.Location, err error) {
panic("unimplemented")
logger.Error("Type definition unimplemented")
return nil, nil
}

// WillCreateFiles implements protocol.Server.
func (h *langHandler) WillCreateFiles(ctx context.Context, params *lsp.CreateFilesParams) (result *lsp.WorkspaceEdit, err error) {
panic("unimplemented")
logger.Error("Will create files unimplemented")
return nil, nil
}

// WillDeleteFiles implements protocol.Server.
func (h *langHandler) WillDeleteFiles(ctx context.Context, params *lsp.DeleteFilesParams) (result *lsp.WorkspaceEdit, err error) {
panic("unimplemented")
logger.Error("Will delete files unimplemented")
return nil, nil
}

// WillRenameFiles implements protocol.Server.
func (h *langHandler) WillRenameFiles(ctx context.Context, params *lsp.RenameFilesParams) (result *lsp.WorkspaceEdit, err error) {
panic("unimplemented")
logger.Error("Will rename files unimplemented")
return nil, nil
}

// WillSave implements protocol.Server.
func (h *langHandler) WillSave(ctx context.Context, params *lsp.WillSaveTextDocumentParams) (err error) {
panic("unimplemented")
logger.Error("Will save unimplemented")
return nil
}

// WillSaveWaitUntil implements protocol.Server.
func (h *langHandler) WillSaveWaitUntil(ctx context.Context, params *lsp.WillSaveTextDocumentParams) (result []lsp.TextEdit, err error) {
panic("unimplemented")
logger.Error("Will save wait until unimplemented")
return nil, nil
}

// WorkDoneProgressCancel implements protocol.Server.
func (h *langHandler) WorkDoneProgressCancel(ctx context.Context, params *lsp.WorkDoneProgressCancelParams) (err error) {
panic("unimplemented")
logger.Error("Work done progress cancel unimplemented")
return nil
}
9 changes: 6 additions & 3 deletions internal/handler/text_document.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,18 @@ func (h *langHandler) DidChange(ctx context.Context, params *lsp.DidChangeTextDo
}

func (h *langHandler) DidCreateFiles(ctx context.Context, params *lsp.CreateFilesParams) (err error) {
panic("unimplemented")
logger.Error("DidCreateFiles unimplemented")
return nil
}

// DidDeleteFiles implements protocol.Server.
func (h *langHandler) DidDeleteFiles(ctx context.Context, params *lsp.DeleteFilesParams) (err error) {
panic("unimplemented")
logger.Error("DidDeleteFiles unimplemented")
return nil
}

// DidRenameFiles implements protocol.Server.
func (h *langHandler) DidRenameFiles(ctx context.Context, params *lsp.RenameFilesParams) (err error) {
panic("unimplemented")
logger.Error("DidRenameFiles unimplemented")
return nil
}

0 comments on commit e7a765e

Please sign in to comment.