Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: process values.yaml files #111

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

qvalentin
Copy link
Collaborator

@qvalentin qvalentin commented Sep 5, 2024

The plan would be to support the following for values.yaml files:

  • autocompletion
  • go-to-references

TOOD:

  • check that yamlls autocomplete is still working
  • Make valuesfiles use the document store, to only store them once and remove WatchedFiles

@qvalentin qvalentin force-pushed the feature/yaml-files-as-documents branch 2 times, most recently from 51f412c to d2de0c4 Compare September 6, 2024 10:29
@qvalentin qvalentin force-pushed the feature/yaml-files-as-documents branch from b718078 to b8bbf58 Compare October 6, 2024 11:52
@qvalentin qvalentin force-pushed the feature/yaml-files-as-documents branch from f2f76d4 to 7101b60 Compare October 14, 2024 18:03
@qvalentin qvalentin force-pushed the feature/yaml-files-as-documents branch from 9b828a6 to 3c2d914 Compare November 10, 2024 15:01
qvalentin added a commit to qvalentin/helm-ls.nvim that referenced this pull request Nov 15, 2024
@qvalentin
Copy link
Collaborator Author

@CodiumAI-Agent /review

@CodiumAI-Agent
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Refactoring Needed
The TemplateHandler class has multiple responsibilities (handling templates, diagnostics, hover, completion, etc.), which could be split into more focused classes to improve maintainability and testability.

Performance Concern
The DocumentStore class uses a sync.Map which might not be the most efficient structure for the use case, especially under high load or large number of documents. Consider benchmarking and possibly using alternative data structures.

Error Handling
The NewConnector function in yamlls.go starts a subprocess for YAML language server but does not handle potential errors robustly, such as failure to start the process or issues with the command path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants