Add CoC configuration #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #75 |
The CoC configration is set in coc-settings.json. The added section explains how to configure helm_ls with CoC plugin.
metal3d
force-pushed
the
feat-coc-configuration
branch
from
1d0ab40 to
4b7e9c8
Compare
qvalentin
reviewed
Apr 12, 2024
| "helm": { | ||
| "command": "helm_ls", | ||
| "args": ["serve"], | ||
| "filetypes": ["yaml", "helm", "helmfile"], |
There was a problem hiding this comment.
Im not sure about having yaml here.
How did you setup the filetypes helm and helmfile in your config? With towolf/vim-helm?
There was a problem hiding this comment.
Yes right.
Maybe I can remove yaml from the list. I will do it today.
| @@ -178,6 +178,33 @@ settings = { | |||
| See [examples/nvim/init.lua](https://github.com/mrjosh/helm-ls/blob/master/examples/nvim/init.lua) for an | |||
| complete example, which also includes yaml-language-server. | |||
|
|
|||
| #### Neovim + CoC plugin | |||
|
|
|||
| Using the [coc.nvim](https://github.com/neoclide/coc.nvim) plugin, you don't need the previous configuration in lua. Coc will handle the configuration instead. | |||
There was a problem hiding this comment.
you don't need the previous configuration in lua
Maybe we should restructure the readme to something like:
Neovim config
explain filetypes etc (anything that must be done for both nvim-lspconfig and coc)
nvim-lspconfig
explain setup with nvim-lspconfig
coc
explain setup with coc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CoC configration is set in coc-settings.json. The added section explains how to configure helm_ls with CoC plugin.