Bug fix: Only reset a failed state if present to avoid error

[andanotheruser]

Description

Fixes an issue where a failed state is reset while none is present, leading to an error and the playbook failing:

  TASK [ansible-mariadb-galera-cluster : manage_node_state | reset failed status (otherwise service can't be stopped)] ***
  fatal: [node2]: FAILED! => {"changed": false, "cmd": ["systemctl", "reset-failed", "mariadb"], "delta": "0:00:00.007486", "end": "2024-11-14 11:43:51.597408", "msg": "non-zero return code", "rc": 1, "start": "2024-11-14 11:43:51.589922", "stderr": "Failed to reset failed state of unit mariadb.service: Unit mariadb.service not loaded.", "stderr_lines": ["Failed to reset failed state of unit mariadb.service: Unit mariadb.service not loaded."], "stdout": "", "stdout_lines": []}
  skipping: [node1]

This change ensures a failed state is only reset if it is present and will fix the merge request pipeline for #227, #229 and #230

Related Issue

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

• I have read the CONTRIBUTING document.
• I have run the pre-merge tests locally and they pass.
• [] I have updated the documentation accordingly. -> No change required.
• [] I have added tests to cover my changes. -> Nothing new required.
• All new and existing tests passed.

[andanotheruser]

Not yet sure why this fails on Rocky.

[andanotheruser]

Not yet sure why this fails on Rocky.

Found it.

mariadb_systemd_service_name must include the full name. Ansible will fail with mariadb on some distributions, as it does not have the key in the dict: ansible_facts.services[mariadb_systemd_service_name].state, however, using the full unit name solves this.

[andanotheruser]

@eRadical This MR will fix an issue that causes the pipeline of my other two MRs to fail. :)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[andanotheruser]

@eRadical @elcomtik Hey there! The bot is about to close this MR due to lack of activity.

The whole point of this comment is to point this out and stop the bot at the same time. :)