Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to solve memory leak #240

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

mortenholmgaard
Copy link

This change make it possible to fix a memory leak in leaking listener in LocationGooglePlayServicesProvider.java and LocationGooglePlayServicesWithFallbackProvider.java

private var locationControl: SmartLocation.LocationControl? = null
locationControl = SmartLocation.with(context).location()
locationControl!!.oneFix().start { location ->
...
}

override fun onDestroy() {
    locationControl?.destroy()
    super.onDestroy()
}

@mortenholmgaard mortenholmgaard mentioned this pull request Jun 25, 2018
@ugurcany
Copy link

ugurcany commented Aug 1, 2018

@mrmans0n please merge this pull request since it resolves a critical memory leak issue. thanks for the library.

@christocracy
Copy link

@mortenholmgaard if you hope to have a PR taken seriously, you might want to rebase your branch before submitting:

  • Fix
  • Fix
  • Fix
  • Fix
    .
    .
    .
    etc

@mortenholmgaard
Copy link
Author

mortenholmgaard commented Aug 5, 2018

I do not really expect it to be merge because there do not seem to any activity on this lib from the author any way, so it was mostly for my self and others with same problem. So I did not want to spend time on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants