-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.7.13 http listeners #631
Open
oliverhausler
wants to merge
40
commits into
mrniko:master
Choose a base branch
from
oliverhausler:1.7.13-http-listeners
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… without contentType signature
… Map to HttpParams
…tener unexpectedly throws
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added HttpListener
I removed
config.setAllowCustomRequests()
as we can derive that setting from the number ofHttpListener
s being set (no listeners -> no custom requests).Http requests are currently not wired through the
AuthorizationListener
, only socket.io requests. We may need to manage this or add a secondAuthorizationListener
. Not sure.Code also needs to be documented, but I would want to get a first feedback, and if you want to merge this at all.
Improved AuthorizationListener
AuthorizationListener
can now respond with a complete response, which gives control over response status, body and headers. A socket.io request can be terminated early or redirected, or a specific error status can be returned to the caller, without establishing the socket.io socket at all (which would be quite expensive).AuthorizationListener
can seed the client store. Instead creating an empty store after authorization,setClientData()
will put data into the client store, which can later be retrieved asclient.get()
.PR is based on 1.7.13 (last stable version).