Try disabling HDF5 locking (dask#9154)

mrocklin · Jun 3, 2022 · 5079288 · 5079288
1 parent cfca592
commit 5079288
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -29,6 +29,7 @@ jobs:
       PYTHON_VERSION: ${{ matrix.python-version }}
       PARALLEL: "true"
       COVERAGE: "true"
+      HDF5_USE_FILE_LOCKING: "FALSE"
 
     steps:
       - name: Checkout source

diff --git a/dask/dataframe/io/hdf.py b/dask/dataframe/io/hdf.py
@@ -76,7 +76,7 @@ def to_hdf(
     compute : bool
         Whether or not to execute immediately.  If False then this returns a
         ``dask.Delayed`` value.
-    lock : Lock, optional
+    lock : bool, Lock, optional
         Lock to use to prevent concurrency issues.  By default a
         ``threading.Lock``, ``multiprocessing.Lock`` or ``SerializableLock``
         will be used depending on your scheduler if a lock is required. See

diff --git a/dask/tests/test_distributed.py b/dask/tests/test_distributed.py
@@ -375,11 +375,6 @@ def test_blockwise_dataframe_io(c, tmpdir, io, fuse, from_futures):
     pd = pytest.importorskip("pandas")
     dd = pytest.importorskip("dask.dataframe")
 
-    # TODO: this configuration is flaky on osx in CI
-    # See https://github.com/dask/dask/issues/8816
-    if from_futures and sys.platform == "darwin":
-        pytest.xfail("This test sometimes fails on osx in CI")
-
     df = pd.DataFrame({"x": [1, 2, 3] * 5, "y": range(15)})
 
     if from_futures: