-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Powershell on Windows support #84
base: master
Are you sure you want to change the base?
Conversation
Sorry for the delay in response I was OOO at a conference. This looks great! 🎉 Really appreciate the work here. ❤️ Do you have thoughts on how we can integrate the Powershell testing into the CI? (I also don't have a Windows machine to verify manually.) |
@mroth Not sure on CI based tests yet. So far I have only run
|
I approved the PR running in CI, so you should be able to see the output there as well for integration tests now. The integration tests are (unfortunately? fortunately?) currently all still implemented in Aruba with Ruby. You can see 867661a as an example of what it looked like to add another shell to the test grid (this was also the PR that added multi-shell support to integration tests). A few changes there should be enough to get it to work locally -- I suspect there might then have to be some other changes in the GitHub Actions scripts to only run PS tests on Windows runners, etc, but that part should hopefully be straightforward. |
Building on work in #14: