Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated CycleGAN with correct Linting changes #33

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Updated CycleGAN with correct Linting changes #33

wants to merge 8 commits into from

Conversation

pascalempucl
Copy link
Collaborator

No description provided.

jmontalt
jmontalt reviewed Sep 5, 2022
View reviewed changes
tensorflow_mri/python/models/cycle_gan.py Show resolved Hide resolved
tensorflow_mri/python/models/cycle_gan.py Show resolved Hide resolved
tensorflow_mri/python/models/cycle_gan.py Show resolved Hide resolved
tensorflow_mri/python/models/cycle_gan.py Show resolved Hide resolved
tensorflow_mri/python/models/cycle_gan.py Show resolved Hide resolved
tensorflow_mri/python/models/cycle_gan.py Outdated Show resolved Hide resolved
tensorflow_mri/python/models/cycle_gan.py Show resolved Hide resolved
tensorflow_mri/python/models/cycle_gan.py Show resolved Hide resolved
tensorflow_mri/python/models/cycle_gan.py Show resolved Hide resolved
jmontalt
jmontalt requested changes Sep 26, 2022
View reviewed changes
Copy link
Member

@jmontalt jmontalt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! To minimize code duplication, I would like to merge the 2D and 3D implementations into one, similar to how other models such as the U-Net are implemented. Let's have a chat offline about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmontalt jmontalt jmontalt requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pascalempucl @jmontalt