rename passFirst to skipFirst

mrspartak · May 30, 2020 · 52ff696 · 52ff696
1 parent b53a79f
commit 52ff696
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/orm/hasura.js b/src/orm/hasura.js
@@ -436,23 +436,23 @@ class Hasura {
 	async subscribeToMore(parameters, callback, settings = {}) {
 		settings = __.mergeDeep(
 			{
-				passFirst: false,
+				skipFirst: true,
 			},
 			this.params.query,
 			settings,
 		);
 
 		callback(await this.query(parameters, settings));
 
-		let firstPassed = settings.passFirst;
+		let skippedFirst = !settings.skipFirst;
 		const subSettings = __.mergeDeep({}, this.params.subscribe, settings);
 		return this.subscribe(
 			parameters,
 			(response) => {
-				if (firstPassed === true) {
+				if (skippedFirst === true) {
 					callback(response);
 				} else {
-					firstPassed = true;
+					skippedFirst = true;
 				}
 			},
 			subSettings,

diff --git a/tests/subscription.js b/tests/subscription.js
@@ -294,7 +294,7 @@ test.serial('subscribe to more works', (t) => {
 	});
 });
 
-test.serial('subscribe to more firstPass', (t) => {
+test.serial('subscribe to more skipFirst', (t) => {
 	t.timeout(2000);
 	let events = 0;
 	const orm = t.context.orm;
@@ -312,7 +312,7 @@ test.serial('subscribe to more firstPass', (t) => {
 				if (events === 2) resolve();
 			},
 			{
-				passFirst: true,
+				skipFirst: false,
 			},
 		);
 		t.true(typeof unsub === 'function');