This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Usability improvements #28
Open
ooeygui
wants to merge
6
commits into
ms-iot:master
Choose a base branch
from
ooeygui:dev/lamadio/env_cleanup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amelhassan
approved these changes
Sep 8, 2021
lilustga
reviewed
Sep 8, 2021
ros_msft_luis/launch/luis.launch
Outdated
<param name="kwregion" value="Enter your location mentioned in the speech studio" /> | ||
<param name="keywordpath" value="Enter the location of the of .table file that you downloaded from the speech studio" /> | ||
<param name="keyword" value="Enter your custom keyword" /> | ||
<param name="luiskey" value="$(arg robotId)" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be "$(arg azure_cs_luis_key)"
lilustga
reviewed
Sep 8, 2021
ros_msft_luis/launch/luis.launch
Outdated
@@ -1,11 +1,23 @@ | |||
<launch> | |||
<arg name="azure_cs_luis_key" default="$(env azure_cs_luis_key)"/> | |||
<arg name="azure_cs_luis_endpoint" default="$(env azure_cs_luis_endpoint)"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes endpoint required to run the launch file, should it be optional?
PranavDhulipala
suggested changes
Sep 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (root_object)
{
// is this "topScoringIntent": "Move Arm Backward" on root?
JSON_Object *topScoringIntent_object = json_object_dotget_object(root_object, "topScoringIntent");
if (topScoringIntent_object)
{
intent.topIntent = json_object_dotget_string(topScoringIntent_object, "intent");
if (!intent.topIntent.empty())
{
intent.score = (float)json_object_get_number(topScoringIntent_object, "score");
score = intent.score;
}
}
// Process the entities array
JSON_Array *entities_array = json_object_get_array(root_object, "entities");
if (entities_array)
{
size_t count = json_array_get_count(entities_array);
for (size_t i = 0; i < count; i++)
{
JSON_Object *entity_object = json_array_get_object(entities_array, i);
if (entity_object)
{
std::string type = json_object_dotget_string(entity_object, "type");
std::string entity = json_object_dotget_string(entity_object, "entity");
if (type == "builtin.keyPhrase")
{
intent.dimension.unit = entity;
}
if (type == "builtin.number")
{
intent.dimension.value = std::stof(entity);
}
}
}
}
}
ooeygui
force-pushed
the
dev/lamadio/env_cleanup
branch
from
September 24, 2021 20:49
6250091
to
8b1ba5f
Compare
lilustga
approved these changes
Sep 24, 2021
This change needs to be redone. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.