Allow decoding raw strings #235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannotti
reviewed
Oct 30, 2023
jannotti
reviewed
Oct 30, 2023
Comment on lines
+29
to
+31
| * Note that this option only applies to string values, not map keys. Additionally, when | ||
| * enabled, raw string length is limited by the maxBinLength option. | ||
| */ |
There was a problem hiding this comment.
Why not do this for map keys as well?
There was a problem hiding this comment.
This library doesn't support binary keys, so I decided to skip that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to skip UTF-8 decoding of strings when you enable the
rawStringsdecoding option.This is useful because I have encountered some encoded msgpack strings which do not contain valid UTF-8 data, and without a feature like this, it would be impossible to decode them properly.
According to the msgpack spec, this ability is encouraged: