Check if CMO label already exists in SMILE #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if CMO label already exists in SMILE
Briefly describe changes proposed in this pull request:
1. Added a check to determine if a CMO sample label is already in use in SMILE for a different sample.
This may be the case when a request/sample is published to the IGO_NEW_REQUEST topic and may have a legacy CMO label in the data being published by/from IGO.
During an effort to recover legacy labels for samples we found that there are duplicates within the legacy IGO data.
The
label-generator
will now log and report such a case:We can catch these events in a datadog monitor.
Crossing T's and dotting I's
Please follow these checklists to help prevent any unexpected issues from being introduced by the changes in this pull request. If an item does not apply then indicate so by surrounding the line item with
~~
to strikethrough the text. See basic writing and formatting syntax for more information.I. Data model checklist
Please follow these checks if any changes were made to any classes in the web, service, or persistence layers.
Code checks:
Unit tests were updated in relation to updates to the mocked test data.II. Message handlers checklist:
Changes introduced affect the workflow of incoming messages.If no unit tests were updated or added, then please explain why: Tested on the dev server.
Please describe how the workflow and messaging was tested/simulated:
Describe your testing environment:
Other: [insert details on how messages were published or simulated for testing]
II. Configuration and/or permissions checklist:
If applicable, a new account was set up and the account credentials and keys are checked into smile-configuration.Account credentials and keys were shared with the appropriate parties.General checklist: