Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAM support #11

Closed
ppararaj opened this issue Jul 7, 2021 · 7 comments
Closed

CRAM support #11

ppararaj opened this issue Jul 7, 2021 · 7 comments
Labels
wontfix This will not be worked on

Comments

@ppararaj
Copy link

ppararaj commented Jul 7, 2021

Hello,
Thanks for the software. I was able to successfully run this on a several BAM files, but I was wondering if there are plans to include support for CRAM format?

I receive the following error when trying to run a CRAM file and looks like a modification of bamUtils will be required:

Error in bamUtils::bam.cov.tile(bam, window = as.numeric(window), chunksize = 1e+06,  :
  Cannot open BAM. A valid BAM for 'bam.file' must be provided.
Calls: fragCounter -> PrepareCov -> <Anonymous>
In addition: Warning message:
In readChar(check_gz, 4) :
  text connection used with readChar(), results may be incorrect
Execution halted
@ShaiberAlon
Copy link
Collaborator

Hi @ppararaj ,

Thank you for your interest in our tool. We don't currently have support for CRAM files and we don't have immediate plans to add this support (at least for now). What we do plan is to add an options for users to provide coverage counts from 3rd party tools and then just apply our GC and mappability correction (hoping to post updates here soon: #12 ). An (often superior) alternative to the coverage correction offered by fragCounter is using dryclean. Dryclean works well with uncorrected read depth counts.

There are many tools that offer fast coverage depth computations, for example: megadepth

If you are using fragCounter because you wish to use JaBbA, then you can use a tool of your choice for coverage depth calculation and supply that as input for JaBbA (with or without dryclean processing).

@ShaiberAlon ShaiberAlon added the wontfix This will not be worked on label Jul 8, 2021
@rdmorin
Copy link

rdmorin commented Jul 8, 2021

We're working with @mskilab on a meta-analysis of lymphomas. This is a show-stopper for us at the moment. Any thoughts on when this new functionality will become available?

@mskilab
Copy link
Collaborator

mskilab commented Jul 9, 2021 via email

@rdmorin
Copy link

rdmorin commented Jul 9, 2021

That would be great. Thanks Marcin!

@mskilab
Copy link
Collaborator

mskilab commented Jul 9, 2021

hi all - just added cram support and pushed to master --> please give it a spin and let us know! You will need to reinstall mskilab/bamUtils as well. Best-Marcin

@ppararaj
Copy link
Author

Hello,
I've tested the new feature on a some GRCh37 CRAM files and it appear to work without issue. Thank you.

@mskilab
Copy link
Collaborator

mskilab commented Jul 10, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants