Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats::aggregate now renamed argument formula to x #33

Merged

Conversation

xtYao
Copy link
Collaborator

@xtYao xtYao commented Nov 7, 2023

Description:

  • Renaming the "formula" argument in "stats::aggregate" to "x"
  • Latest R base no longer has "formula" as the first argument of "stats::aggregate" function, causing gTrack to fail when "vaggregate" function is called. See https://rdrr.io/r/stats/aggregate.html

Changes:

  • Renaming the "formula" argument in "stats::aggregate" to "x"

Impact:

  • gTrack would fail without this change if vaggregate is triggered anywhere along the call stack

@xtYao xtYao self-assigned this Nov 7, 2023
@xtYao xtYao requested a review from imielinski November 7, 2023 23:09
@xtYao
Copy link
Collaborator Author

xtYao commented Nov 7, 2023

Somehow this is not the case in the unit tests. Maybe a diff in R versions used.

@shihabdider shihabdider merged commit 4aa01d0 into mskilab-org:master Nov 8, 2023
0 of 3 checks passed
shihabdider added a commit that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants