-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5524 add pick list reports #5535
Conversation
Bundle size differenceComparing this PR to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please remove convert_data_js, we would only add them when used/needed.
I've tried to run outbound report, had problems, need to add the following to see what the issue is: 5524-add-pick-list-reports...5524-add-pick-list-reports(Better-logging-for-report-generation)
I know it's not something that you would have created, but good to see this error (can you add to this please)
Also can you please add an -o flag or something like that to UpsertReportsJson, to upsert reports in dev mode (overwrite existing reports).
I am keen to get this approved, we can decide on the types we want in reports before 2.5 is out
"install", | ||
"--cwd", | ||
&convert_dir, | ||
"--no-lockfile", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh wow on second run it's much faster, personally I would optimise this by running in parallel, but I don't think we should do this especially since I would pivot from extism to BoaJS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks looks great
Followup issues for CLI added here |
Fixes #5534
π©π»βπ» What does this PR do?
Adds remaining standard (picklist) reports
π Any notes for the reviewer?
I'm unsure of the context / subcontext requirements of the pick list reports.
Awaiting discussion to confirm
π§ͺ Testing
π Documentation