5990(1) Allow custom props for table cells without creating new component.

[CarlosNZ]

Basically a pre-requisite for #5990, but just wanted to make this is separate PR as it's essentially a separate refactor of existing functionality and didn't want to over-complicate #5990 proper.

👩🏻‍💻 What does this PR do?

It's been an ongoing hassle when making Table cells that require more props than are available from the table provider. If you try and define a new Component inline, you get problems with losing input focus on re-render. So you have to define a component outside the table column definitions. But even with that, I was having problems implementing what I need for #5990 without getting input focus issues on the Number Input.

So this PR just provides a very simple mechanism to pass props into whatever cell is defined in the Cell field of a table column definitions -- the column definition can take an additional cellProps property, which is then passed into the Cell component where it is rendered (inside DataRow)

I've implemented it just in one place to demonstrate that it works as expected -- in StocktakeLineEditTables. There will be a more substantial implementation in #5990 proper,

💌 Any notes for the reviewer?

Any potential problems? I don't think so, but haven't tried too hard to break it.

🧪 Testing

Check that the "Counted Number Of Packs" field in the Stocktake Line Edit modal behaves exactly the same as before.

[github-actions]

Bundle size difference

Comparing this PR to main

Old size	New size	Diff
5.16 MB	5.16 MB	-5 B (-0.00%)

[lache-melvin]

Happy with this as it is, better than the separately defined Cells (is there a plan to clean these up?) but if we can type it, that would be my preference 🙏

[lache-melvin]

Hm ... I played around with something like this:

cellProps?: Omit<ComponentProps<Column<T>['Cell']>, keyof CellProps<T>>;

It's not quite right but might be good to experiment with for a sec? Would be nice for cellProps to be typed based on the Cell

[CarlosNZ]

Yeah, I had it almost working too. I'll have another look, won't spend too long on it.

[mark-prins]

thanks - that was my concern too. allowing untyped spreading and working around the type system isn't ideal

[CarlosNZ]

The difficulty is that the Cell prop itself isn't actually correctly defined: JSXElementConstructor<CellProps<T>> but it can can have props beyond CellProps<T>, so it's hard to define props type for props the Cell property isn't actually aware of (if that makes any sense).

I tried passing in a second generic U to the Column definition, but this requires every column to have the same props for its "Cell" which is obviously not the case.

I think we inherently lose type information by defining Cell like this. Any other suggestions?