Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6263 suggest next date from vax card #6302

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

lache-melvin
Copy link
Contributor

Fixes #6263

👩🏻‍💻 What does this PR do?

Use next vaccination date for encounter suggested date:
Screenshot 2025-01-28 at 5 57 51 PM

💌 Any notes for the reviewer?

🧪 Testing

  • Have some vaccine course doses configured for the vax card
  • Give vaccinations so that the suggested date of one of the doses is in the future
  • Mark encounter as visited
  • Schedule next encounter modal should recommend that date for the next encounter
  • From new encounter, set up so suggest date in past
  • No recommended date in the next encounter modal
  • From new encounter, give all doses so there are no suggested dates
  • No recommended date in the next encounter modal

📃 Documentation

  • Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • These areas should be updated or checked:
    1.
    2.

@github-actions github-actions bot added this to the v2.6.0 milestone Jan 28, 2025
Copy link

Bundle size difference

Comparing this PR to main

Old size New size Diff
5.22 MB 5.22 MB 409 B (0.01%)

@aimee-mcneil-melville aimee-mcneil-melville self-assigned this Jan 29, 2025
@aimee-mcneil-melville aimee-mcneil-melville removed their assignment Jan 29, 2025
Copy link
Contributor

@aimee-mcneil-melville aimee-mcneil-melville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! I tested with a few different course timeframes also

@aimee-mcneil-melville aimee-mcneil-melville self-assigned this Jan 29, 2025
Base automatically changed from 6262-schdule-next-encounter-modal to develop January 29, 2025 23:01
@lache-melvin lache-melvin merged commit 0f4dc76 into develop Jan 29, 2025
6 checks passed
@lache-melvin lache-melvin deleted the 6263-suggest-next-date-from-vax-card branch January 29, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest the date of the next vaccine as the date of the next scheduled encounter
2 participants