Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6230 not all periods shows up on first load #6350

Merged
merged 2 commits into from
Jan 30, 2025
Merged

6230 not all periods shows up on first load #6350

merged 2 commits into from
Jan 30, 2025

Conversation

roxy-dao
Copy link
Contributor

Fixes #6230

👩🏻‍💻 What does this PR do?

Up max periods shown historically/future. Also add message to clearly state why periods are missing from selection.

🧪 Testing

  • Have more than 5 periods both in the past and future
  • Create program requisitions
  • Only first 5 historic/future periods should show

📃 Documentation

  • Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • These areas should be updated or checked:
    1.
    2.

@github-actions github-actions bot added this to the 2.5.1 milestone Jan 30, 2025
@github-actions github-actions bot added bug Something is borken Team Ruru 🦉 Roxy, Ferg, Noel Severity: Hotfix Extreme user impact. Can't finalise invoices. Needs patch release and installation immediately. labels Jan 30, 2025
@fergie-nz fergie-nz self-assigned this Jan 30, 2025
@github-actions GitHub Actions
Copy link

Bundle size difference

Comparing this PR to main

Old size New size Diff
5.15 MB 5.15 MB 484 B (0.01%)

fergie-nz
fergie-nz approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@fergie-nz fergie-nz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks great

@roxy-dao roxy-dao merged commit 02c1b4b into main Jan 30, 2025
5 of 7 checks passed
@roxy-dao roxy-dao deleted the 6230-Not-all-periods-shows-up-on-first-load branch January 30, 2025 01:14
@roxy-dao roxy-dao mentioned this pull request Jan 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fergie-nz fergie-nz fergie-nz approved these changes

Assignees

@fergie-nz fergie-nz

Labels
bug Something is borken Severity: Hotfix Extreme user impact. Can't finalise invoices. Needs patch release and installation immediately. Team Ruru 🦉 Roxy, Ferg, Noel
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@roxy-dao @fergie-nz