Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6251 filter by next of kin name #6351

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Conversation

lache-melvin
Copy link
Contributor

Fixes #6251

πŸ‘©πŸ»β€πŸ’» What does this PR do?

Adds next of kin filter to patient list view

I have patient with Basil Coriander as next of kin:
Screenshot 2025-01-30 at 2 43 24β€―PM

Search by name:
Screenshot 2025-01-30 at 2 43 41β€―PM

πŸ’Œ Any notes for the reviewer?

This is currently just using name field, which is [lastName], [firstName]. Same filter applies when e.g. creating new prescription. I figure this is okay for first pass, and get feedback, might need to support searching in either order?

πŸ§ͺ Testing

  • Go to patient list view
  • There is a next of kin option in the filters
  • Search by the next of kin name of a patient
  • That patient appears

πŸ“ƒ Documentation

  • Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • These areas should be updated or checked:
    1.
    2.

@github-actions github-actions bot added this to the v2.6.0 milestone Jan 30, 2025
Copy link

Bundle size difference

Comparing this PR to main

Old size New size Diff
5.26 MB 5.26 MB 312 B (0.01%)

@Chris-Petty Chris-Petty self-assigned this Jan 30, 2025
Copy link
Contributor

@Chris-Petty Chris-Petty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ur so fas

image

Works sweet. I wonder UI wise if it might be useful showing a column of the next of kin name? Just cause I apparently have 4 different "Richard Moizeau"s and all these patients actually have a different next of kin record. Well... the column wouldn't really clarify in this case, but if you have many Richards with different surnames it might help!

@lache-melvin
Copy link
Contributor Author

I wonder UI wise if it might be useful showing a column of the next of kin name?

Was thinking this too, will make new issue, to do once next of kin node exposed on patient. Also not sure if we should show as 2 sep columns, or one Moizeau, Richard ?

@lache-melvin lache-melvin merged commit 79daf0a into develop Jan 30, 2025
7 checks passed
@lache-melvin lache-melvin deleted the 6251-filter-by-next-of-kin-name branch January 30, 2025 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a filter for the Next of kin's name (first and last) on the patient list
2 participants