Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to disable discovery #6363

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Conversation

jmbrunskill
Copy link
Contributor

@jmbrunskill jmbrunskill commented Jan 30, 2025

Fixes #5018

πŸ‘©πŸ»β€πŸ’» What does this PR do?

Adds a new option you can put in your local.yaml file to turn on/off discovery.

The default Auto will disable discovery in Debug Build (normal workflow for devs)

server:
    discovery: Auto 
server:
    discovery: Enabled 
server:
    discovery: Disabled

πŸ’Œ Any notes for the reviewer?

Haven't removed my old catch_panic_unwind code in this PR, should I?

πŸ§ͺ Testing

  • Start server in the office see if we get any crashes due to astro-dns in Auto mode
  • Check you can turn on the discovery service with discovery: Enabled
  • Check that discovery works correctly in Window RC Build for 2.6 (When available)

πŸ“ƒ Documentation

  • Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • These areas should be updated or checked:
    1.
    2.

@github-actions github-actions bot added this to the v2.6.0 milestone Jan 30, 2025
@github-actions github-actions bot added bug Something is borken Team Piwakawaka James, Carl, John, Zachariah Severity: High Bugs breaking core functionality or with no/unacceptable workaround. High impact. Next patch release labels Jan 30, 2025
server/server/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@andreievg andreievg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmbrunskill, look good, as per out discussion, may need a little bit of tweaking. We in dev atm so happy with it as is or with those small tweaks after this approval

@jmbrunskill jmbrunskill merged commit 243ba2b into develop Jan 30, 2025
0 of 2 checks passed
@jmbrunskill jmbrunskill deleted the 5018-non-discovery branch January 30, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is borken Severity: High Bugs breaking core functionality or with no/unacceptable workaround. High impact. Next patch release Team Piwakawaka James, Carl, John, Zachariah
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discovery intermittently crashes
2 participants