5863 Add overwrite flag to upsert json cli #6377
Conversation
github-actions
bot
added
enhancement
There was a problem hiding this comment.
This is great ! Thanks @EthanMcQ-TMF
I just noticed that we don't error on UpsertReports and ReloadEmbeddedReports, I think we should. I know it's not really part of this PR scope, but can you please add.
Is there any extra docs needed considering this is a dev tool?
There is this issue, can you please add comment: #5037
@andreievg I'm sorry, error in what scenario exactly? This makes it sound like you want this feature to just always throw an error... |
server/cli/src/cli.rs
Outdated
| let connection_manager = get_storage_connection_manager(&settings.database); | ||
| let con = connection_manager.connection()?; | ||
|
|
||
| let _ = StandardReports::load_reports(&con, true); |
There was a problem hiding this comment.
let _ basically discards the result.
Should be something like StandardReports::load_reports(&con, true)? or StandardReports::load_reports(&con, true).expect("Failed to load reports")
Fixes #5863
👩🏻💻 What does this PR do?
--overwrite / -oflag toupsert-jsoncommand. If used, overwrite any pre-existing reports.reload-embedded-reportscommand. Reloads the embedded reports and overwrites them in the database💌 Any notes for the reviewer?
🧪 Testing
upsert-reportswithout-oflag, observe 0 reports updatedupsert-reportswith-oflag, observe reports being updatedreload-embedded-reports, observe reports being updated📃 Documentation