[new package] crystal 1.15.0 #23200
Open
[new package] crystal 1.15.0 #23200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Biswa96
reviewed
Jan 26, 2025
Biswa96
reviewed
Jan 26, 2025
Co-authored-by: Biswapriyo Nath <[email protected]>
Biswa96
reviewed
Jan 26, 2025
Biswa96
reviewed
Jan 26, 2025
| "${MINGW_PACKAGE_PREFIX}-lld" # needed for linking std_spec | ||
| ) | ||
| source=( | ||
| https://github.com/crystal-lang/crystal/releases/download/1.15.0/crystal-1.15.0-windows-x86_64-gnu-unsupported.zip # stage 0 compiler |
There was a problem hiding this comment.
Suggested change
| https://github.com/crystal-lang/crystal/releases/download/1.15.0/crystal-1.15.0-windows-x86_64-gnu-unsupported.zip # stage 0 compiler | |
| https://github.com/crystal-lang/crystal/releases/download/${pkgver}/crystal-${pkgver}-windows-x86_64-gnu-unsupported.zip # stage 0 compiler |
There was a problem hiding this comment.
The stage 0 compiler is always 1.15.0, it doesn't change with the MSYS2 package version
There was a problem hiding this comment.
But older releases in crystal repository have those compiled tarball also, not the gnu one. Wouldn't future releases have that *-gnu-unsupported.zip ?
There was a problem hiding this comment.
Maybe, but if we always use a recent version of the compiler then I believe Crystal itself can be added to makedepends instead once it is available in MSYS2, so there is never a need to use any version other than 1.15.0 here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Crystal programming language.
Crystal must be compiled from Crystal itself. An initial 1.15.0 compiler is cross-compiled from Ubuntu using a GitHub workflow; the language's forward compatibility guarantee ensures that this initial compiler should be able to build any subsequent 1.x compiler.
Does not include the Crystal-specific package manager yet.