Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for HTTP proxy environemnt variables #369

Closed
wants to merge 1 commit into from

Conversation

jwedel
Copy link

@jwedel jwedel commented May 3, 2024

Fixes #368

Copy link
Owner

@mthmulders mthmulders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot @jwedel. I will merge this and soon publish a release, probably next week.

@jwedel
Copy link
Author

jwedel commented May 3, 2024

@mthmulders what about the failing mutation tests? How can I run them? I just did the mvn verify.

@mthmulders
Copy link
Owner

@mthmulders what about the failing mutation tests? How can I run them? I just did the mvn verify.

Don't worry. The mutation tests run fine, but the integration with the Stryker Dashboard doesn't work for pull requests from other authors then myself. I'm ignoring that for now.

@mthmulders
Copy link
Owner

@mthmulders what about the failing mutation tests? How can I run them? I just did the mvn verify.

On second observation, this may be a different issue. Nevertheless, I'll see how important it is and whether we need to deal with it or not.

@jwedel
Copy link
Author

jwedel commented May 3, 2024

@mthmulders what about the failing mutation tests? How can I run them? I just did the mvn verify.

On second observation, this may be a different issue. Nevertheless, I'll see how important it is and whether we need to deal with it or not.

Just FYI, you may have seen it in the changes, I needed to add a command line option to to failsafe to allow changing the env vars.

When the mutation test also run those tests, the need the same Java args.

@mthmulders
Copy link
Owner

On second observation, this may be a different issue. Nevertheless, I'll see how important it is and whether we need to deal with it or not.

Just FYI, you may have seen it in the changes, I needed to add a command line option to to failsafe to allow changing the env vars.

When the mutation test also run those tests, the need the same Java args.

Good catch, that was the cause! I'll include that when I merge it - but it will not fix the integration issue that I mentioned earlier.

@mthmulders
Copy link
Owner

Closed with 7c2280f, thanks @jwedel!

@mthmulders mthmulders closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respect the HTTPS_PROXY environment variable
2 participants