Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand Ajax API -- add fetchProjectLogs and fetchflowgraph #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Expand Ajax API -- add fetchProjectLogs and fetchflowgraph #37

wants to merge 1 commit into from

Conversation

ruor
Copy link

@ruor ruor commented May 30, 2019

No description provided.

@ruor ruor mentioned this pull request May 31, 2019
Open
mtth
mtth reviewed Jun 5, 2019
View reviewed changes
Copy link
Owner

@mtth mtth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this @ruor! Looks good, just one minor comment.

azkaban/remote.py
'flow': flow,
},
)
except HTTPError:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic here is the same as in get_workflow_info; do you mind extracting it to a helper function (say _extract_workflow_json)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtth mtth mtth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruor @mtth