Add support for ember-simple-auth v7 #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piemonkey
reviewed
Mar 27, 2025
| @@ -35,8 +35,7 @@ | |||
| "@babel/core": "^7.22.10", | |||
| "ember-auto-import": "^2.6.3", | |||
| "ember-cli-babel": "^8.0.0", | |||
| "ember-cli-htmlbars": "^6.3.0", | |||
| "ember-simple-auth": "^6.0.0" | |||
There was a problem hiding this comment.
Hmm, moving this to dependencies was done by @erikap as otherwise it needed an extra import for the addon to be usable in a project.
Unfortunately that discussion was a couple of years ago, so I don't remember much beyond what's in the messages.
There was a problem hiding this comment.
Yea, I read that comment, but I've never seen that problem before so I'm confident it must have been a quirk in the host app's setup.
We use the exact same setup (where we only list the peerDep) in @lblod/ember-mock-login and @lblod/ember-acmidm-login which we use in most of our apps without problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the dependency on ember-simple-auth since it is already a peerDep with a wide range:
ember-mu-login/package.json
Line 84 in 761dec1
This would allow apps to use v7 as well. v7 is API compatible with v5 and v6, so no code changes are needed here.