Merge pull request #15 from muak/FixIssue14

Fixed Issue#14
muak · Jun 24, 2017 · 810b0d4 · 810b0d4
2 parents 8d9445b + d44fbb9
commit 810b0d4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/AiForms.Effects.Droid/AddCommandPlatformEffect.cs b/AiForms.Effects.Droid/AddCommandPlatformEffect.cs
@@ -123,6 +123,7 @@ protected override void OnDetached()
             _layer = null;
             _ripple?.Dispose();
             _ripple = null;
+            _useRipple = false;
         }
 
         protected override void OnElementPropertyChanged(System.ComponentModel.PropertyChangedEventArgs e)

diff --git a/nuget/AiEffects_mac.nuspec b/nuget/AiEffects_mac.nuspec
@@ -2,7 +2,7 @@
 <package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
     <metadata>
         <id>AiForms.Effects</id>
-        <version>0.2.2</version>
+        <version>0.2.3</version>
         <title>AiForms.Effects for Xamarin.Forms</title>
         <authors>kamu</authors>
         <owners>kamu</owners>
@@ -12,12 +12,9 @@
         <description>Xamarin.Forms Effects(add Text/add Command/NumberPicker to a view,alter LineHeight of Label and Editor/Button to flat) for iOS/Android</description>
         <summary></summary>
         <releaseNotes>
-        ## Enhancements 
-
-        [AddCommand] Add EnableSound Property (PullRequests#10)
-            * system sound on/off.
-        [AddCommand] Add SyncCanExecute Property (Issues#9)
-            * synchronize Command's CanExecute to Xamarin.Forms.View's IsEnabled.
+## BugFix
+
+[AddCommand](Android) Not working ripple effect when attached again after detached.(Issue#14)
         </releaseNotes>
         <tags>Xamarin.Forms Effects Command NumberPikcer LineHeight LineSpacing FlatButton Validation SoundEffect</tags>
         <language>en-US</language>