Refactors the pipeline command generation logic from audio.py into a new module, and adds unit tests. #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d structure easier to read.
This is a preparatory step before refactoring the cascading if/then/else logic.
…mbered to git-add pipeline_builder.py)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also deletes the already-commented-out code that would have supported
gstreamer. We should just remove gstreamer from the set of recognized backends.
This reduces a lot of code duplication about how the pipeline commands were
generated, and makes them drastically easier to update and the validate. It
also highlighted a number of surprising discrepancies which should be
investigated.
Makes significant progress on #434, and is close to avoiding any import-time
work from audio.py, which is relevant to #425.