Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed BrowserStorage #173

Merged
merged 2 commits into from
Jan 9, 2025
Merged

fixed BrowserStorage #173

merged 2 commits into from
Jan 9, 2025

Conversation

Dreamlinerm
Copy link
Contributor

  • fixed error if changing datatype of setting
  • fixed deep object
  • fixed cannot copy object by using toRaw

@Dreamlinerm
Copy link
Contributor Author

@mubaidr I fixed the remaining issues with your storage, now even your example page is working 👍😂

@mubaidr mubaidr merged commit a3181d3 into mubaidr:master Jan 9, 2025
2 checks passed
@mubaidr
Copy link
Owner

mubaidr commented Jan 9, 2025

This is awesome!

@Dreamlinerm
Copy link
Contributor Author

@mubaidr I also added a function which applies the stored settings to the default settings, because if you add (or remove) keys to the default settings they get lost if something is stored, because it just gets overwritten.
If you want me to merge this also, I can.
I have worked with pinia and stores a lot 😢.

@mubaidr
Copy link
Owner

mubaidr commented Jan 9, 2025

It should not overwrite the existing settings, but sure please share your code. Or create a pull request, lets review it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants