Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some fixes #4

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add some fixes #4

wants to merge 11 commits into from

Conversation

Foxglove144
Copy link

@Foxglove144 Foxglove144 commented Jan 14, 2024

  1. Add requirements.txt.
  2. Move tokenized input to CUDA in translation.py and token_classification.py.
  3. Fix bug in printing predictions from decoded output in token_classification.py.
  4. Change number of samples per batch during training and eval from 16 to 8 to prevent CUDA out of memory error in summarization.py.
  5. In masked_language_modeling.py, use the evaluate() method to print model perplexity.

token_classification.py Outdated Show resolved Hide resolved
translation.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
Copy link
Owner

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Seems like good improvements to me, but left some comments

@Foxglove144
Copy link
Author

Moved tokenized input to correct device automatically in translation.py, token_classification.py, sequence_classification.py and translation.py

Copy link
Owner

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to leave this PR open, however the goal of this isn't to be device-agnostic, but to be very simplified examples. Which also includes not having accelerate involved in the script itself.

We can keep this up for future people to reference however

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants