🚨 🚨 🚨 Change processors to notebook_processors, introduce post processors 🚨 🚨 🚨 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr introduces a breaking change as we deal with < 0.1.0 and a young API. Once 0.1.0 is released a full deprecation cycle (2 full
0.x.0versions) will be used for any API regressions.This PR changes
processorsin theconfig.yamlfile to benotebook_processorsto introduce the concept ofqmd_processors. As the name suggests, these are meant to apply some sort of post processing to all.qmdfiles in the docs in a project-based way. This is to help make #4 easier by allowing us to inject the javascript syntax needed at the top of each qmd, not just notebook.For now is just raw string modification on the qmd file, eventually might try to come up with a way to make it more notebook-esq