Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --text parameter for matching with keywords within files #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YakovAU
Copy link

@YakovAU YakovAU commented Dec 27, 2024

No description provided.

Copy link
Collaborator

@ODAncona ODAncona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
Thanks for your contribution and the new feature.

Here's are the requested changes:

  1. The should_include_file is based on include and exclude glob pattern. Thus, a new separate function should be made to check for your text filter. Then your function should be integrated into the path.rs file.
  2. The codebase must be updated to the latest version
  3. The unit test should verify the new function. E.g file_contains_text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants