chore: add __str__ method to device

muhlba91 · Dec 12, 2023 · 6498e94 · 6498e94
1 parent 0d45376
commit 6498e94
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/onyx_client/client.py b/onyx_client/client.py
@@ -332,10 +332,10 @@ async def _read_loop(self, include_details: bool = False):
                 if self._shutdown:
                     break
                 if self._event_callback is not None:
-                    _LOGGER.info("Received device: %s", device)
+                    _LOGGER.debug("Received device: %s", device)
                     self._event_callback(device)
                 else:
-                    _LOGGER.warning("Received data but no callback is defined")
+                    _LOGGER.warning("Received data but no callback is defined.")
 
 
 def create(

diff --git a/onyx_client/device/device.py b/onyx_client/device/device.py
@@ -27,6 +27,11 @@ def __init__(
         self.device_mode = device_mode
         self.actions = actions
 
+    def __str__(self):
+        return (
+            f"Device(id={self.identifier}, name={self.name}, type={self.device_type})"
+        )
+
     def __eq__(self, other):
         if isinstance(self, other.__class__):
             return self.identifier == other.identifier

diff --git a/tests/device/test_device.py b/tests/device/test_device.py
@@ -20,6 +20,12 @@ def test_init(self, device_mode):
         assert device.device_type == DeviceType.AWNING
         assert device.device_mode.mode == DeviceType.ROLLERSHUTTER
 
+    def test_str(self, device_mode):
+        assert (
+            str(Device("id", "name", DeviceType.AWNING, device_mode, list(Action)))
+            == "Device(id=id, name=name, type=DeviceType.AWNING)"
+        )
+
     def test_eq(self, device_mode):
         assert Device(
             "id", "name", DeviceType.AWNING, device_mode, list(Action)