Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] POC Bundle size docs #40592

Closed
wants to merge 4 commits into from

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jan 15, 2024

POC for #40591. I timeboxed myself for 1-hour on this:

Preview: https://deploy-preview-40592--material-ui.netlify.app/base-ui/react-slider/

What I was thinking of doing is in the tooltip showing the bundle size of all the modules in a ul > li. We have the data in the JavaScript scope but I ran out of time to render it.

@oliviertassinari oliviertassinari added the scope: docs-infra Specific to the docs-infra product label Jan 15, 2024
@oliviertassinari oliviertassinari changed the title Bundle size docs [docs-infra] POC Bundle size docs Jan 15, 2024
@samuelsycamore
Copy link
Contributor

I think this solution looks much better than the text in #40549! 🙌

@oliviertassinari
Copy link
Member Author

Actually, I was close to make it to work, reopening.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 20, 2024
@oliviertassinari
Copy link
Member Author

Closing this for mui/base-ui#602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: out-of-date The pull request has merge conflicts and can't be merged scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants